[PATCH] D91262: [AArch64][SVE] Allow C-style casts between fixed-size and scalable vectors

Cullen Rhodes via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 18 09:19:29 PST 2020


c-rhodes accepted this revision.
c-rhodes added a comment.
This revision is now accepted and ready to land.

LGTM

I've left one minor comment, if that suggestion works it should be fine to fix it before committing



================
Comment at: clang/lib/Sema/SemaExpr.cpp:7210-7212
+    const auto *BuiltinTy = FirstType->getAs<BuiltinType>();
+    if (!BuiltinTy || !BuiltinTy->isSizelessBuiltinType())
+      return false;
----------------
nit: I think you can just do:
```
if (!FirstType->isSizelessBuiltinType())
  return false;```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91262/new/

https://reviews.llvm.org/D91262



More information about the cfe-commits mailing list