[PATCH] D91485: [clang-tidy] ElseAfterReturn check wont suggest fixes if preprocessor branches are involved

[Stephen Kelly via Phabricator via cfe-commits]

steveire requested changes to this revision.
steveire added inline comments.
This revision now requires changes to proceed.


================
Comment at: clang-tools-extra/clang-tidy/readability/ElseAfterReturnCheck.cpp:34
+      return;
+    auto &Collection = Collections[SM.getFileID(Loc)];
+    assert(Collection.empty() || Collection.back().getEnd() < Loc);
----------------
`auto` needs to be replaced/expanded.


================
Comment at: clang-tools-extra/clang-tidy/readability/ElseAfterReturnCheck.cpp:208
+
+  const auto &ConditionalBranches = Iter->getSecond();
+
----------------
`auto` needs to be replaced/expanded.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91485/new/

https://reviews.llvm.org/D91485