[PATCH] D91162: Give up on evaluating value-dependent potential constexpr before hitting the assertion.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 18 02:28:29 PST 2020


hokein added a comment.

In D91162#2400723 <https://reviews.llvm.org/D91162#2400723>, @hokein wrote:

> oops, this reminds me of the patch https://reviews.llvm.org/D84637 (I should have landed it, sorry), that patch should fix a general recovery-expr crash inside constexpr function body. I think the crash test should be fixed by that (let me check tomorrow).

yeah, confirmed that D84637 <https://reviews.llvm.org/D84637> will fix the crash, I also added the crash case there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91162/new/

https://reviews.llvm.org/D91162



More information about the cfe-commits mailing list