[PATCH] D90441: [X86] Add support for vex, vex2, vex3, and evex for MASM
LiuChen via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Nov 17 17:20:19 PST 2020
LiuChen3 added inline comments.
================
Comment at: clang/lib/AST/Stmt.cpp:795
+ SmallVector<StringRef, 8> Pieces;
+ AsmStr.split(Pieces, "\n\t");
+ std::string MSAsmString;
----------------
pengfei wrote:
> Can we always assume the separator is `\n\t`?
I think so. From the code, we can see '\n\t' will be added to each end of statement:
```
case AOK_EndOfStatement:
OS << "\n\t";
break;
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90441/new/
https://reviews.llvm.org/D90441
More information about the cfe-commits
mailing list