[PATCH] D87956: [IR] add fn attr for no_stack_protector; prevent inlining on mismatch

[Nick Desaulniers via Phabricator via cfe-commits]

nickdesaulniers added inline comments.


================
Comment at: llvm/test/Transforms/Inline/inline_nossp.ll:3
+; RUN: opt -passes='cgscc(inline)' %s -S | FileCheck %s
+; RUN: opt -always-inline -o - -S %s | FileCheck %s
+
----------------
aeubanks wrote:
> nickdesaulniers wrote:
> > aeubanks wrote:
> > > This test fails with the NPM,
> > > `opt -passes=always-inline ...`
> > > 
> > > Does `llvm::isInlineViable()` need to be updated?
> > Thanks for the report.  Is there a Cmake configuration I need to explicitly set to reproduce? `LLVM_USE_NEWPM`?
> Just a new RUN line: `RUN: opt -passes=always-inline -o - -S %s | FileCheck %s`
I think I'm going to back out this patch and the fix ups, and pursue a much simpler approach: https://github.com/ClangBuiltLinux/llvm-project/commit/501847c5239be52bbe32a9c5bd0723e4d0ad2990.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87956/new/

https://reviews.llvm.org/D87956