[PATCH] D91610: [clangd] Add OverriddenBy Relation to index.
Haojian Wu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Nov 17 12:48:42 PST 2020
hokein accepted this revision.
hokein added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang-tools-extra/clangd/index/Relation.h:31
+/// { Subject = A, Predicate = BaseOf, Object = B }.
+/// - "A::Foo is overriden by B::Foo" is represented as
+/// { Subject = A::Foo, Predicate = OverriddenBy, Object = B::Foo }.
----------------
nit: I would explicitly indicate the base hierarchy here, maybe `Derived::Foo() overrides Base::Foo()`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91610/new/
https://reviews.llvm.org/D91610
More information about the cfe-commits
mailing list