[PATCH] D91602: [clang-tidy] Make clang-format and include-order-check coherent

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 17 06:21:54 PST 2020


kadircet added inline comments.


================
Comment at: clang-tools-extra/test/clang-tidy/checkers/llvm-include-order.cpp:1
 // RUN: %check_clang_tidy %s llvm-include-order %t -- -- -isystem %S/Inputs/Headers
 
----------------
njames93 wrote:
> Would it be wise to specify a format style here to ensure they align. Better yet 2 run lines, one that runs clang-tidy with no format, the other specifies a format.
ah sorry, i missed this comment :/ i am not sure how the formatting vs. generated edits interact. is it enough to have `--format-style=LLVM` and ensure the run lines produce the same ordering?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91602/new/

https://reviews.llvm.org/D91602



More information about the cfe-commits mailing list