[PATCH] D91610: [clangd] Add OverridenBy Relation to index.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 17 06:07:28 PST 2020


hokein added a comment.

Thanks! I think we need to bump the index version number (in `index/Serialization.cpp`) in order to let the index pick up this change.



================
Comment at: clang-tools-extra/clangd/index/Relation.h:29
 /// For an example "A is a base class of B" may be represented
 /// as { Subject = A, Predicate = BaseOf, Object = B }.
 struct Relation {
----------------
nit: can you add an override example here?


================
Comment at: clang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp:879
   } TestCases[] = {
-    {
-      R"cpp(
+      {
+          R"cpp(
----------------
looks like these changes are unexpected?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91610/new/

https://reviews.llvm.org/D91610



More information about the cfe-commits mailing list