[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

[Sam Elliott via Phabricator via cfe-commits]

lenary added a comment.

In D91442#2399341 <https://reviews.llvm.org/D91442#2399341>, @abidh wrote:

> In D91442#2399200 <https://reviews.llvm.org/D91442#2399200>, @lenary wrote:
>
>> I'm worried about this change - I *think* it doesn't cover the existing behaviour of a baremetal GCC toolchain being installed into the same prefix as clang, and clang automatically picking up that baremetal gcc toolchain. What should we expect to do here? This is especially an issue if you're trying to make a relocatable toolchain tarball, where specifying `--gcc-toolchain` automatically is difficult.
>
> Would it be possible to use a relative path with --gcc-toolchain then this can be checked in either RISCVToolChain.cpp or GNU.cpp and adjusted accordingly?

The GCC toolchain, when given a relative path, already interprets it relative to the working directory the compiler was invoked from, not the directory the compiler is located in, iirc.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91442/new/

https://reviews.llvm.org/D91442