[PATCH] D88393: [cfe][M68k] (Patch 7/8) Basic Clang support

[Renato Golin via Phabricator via cfe-commits]

rengolin added inline comments.


================
Comment at: clang/lib/Basic/Targets.cpp:314
+    default:
+      return new M68kTargetInfo(Triple, Opts);
+    }
----------------
No support for bare-metal?


================
Comment at: clang/lib/Basic/Targets/M68k.cpp:123
+    "d0", "d1", "d2", "d3", "d4", "d5", "d6", "d7",
+    "a0", "a1", "a2", "a3", "a4", "a5", "a6", "a7"};
+
----------------
no "sp", "pc", etc? Or are all of them aliased to those?


================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:8083
+
+// TODO Does not actually work right now
+void M68kTargetCodeGenInfo::setTargetAttributes(
----------------
That's an odd comment... :)

What doesn't work right now? Something or everything?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88393/new/

https://reviews.llvm.org/D88393