[PATCH] D91601: [clang-tidy] Fix an abseil-redundant-strcat-calls crash on 0-parameter StrCat().

Dmitri Gribenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 17 01:52:03 PST 2020


gribozavr2 accepted this revision.
gribozavr2 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clang-tidy/abseil/RedundantStrcatCallsCheck.cpp:51
+  if (Call->getNumArgs() == 0)
+    return;
   // Remove 'Foo('
----------------
Remove the whole call instead of returning?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91601/new/

https://reviews.llvm.org/D91601



More information about the cfe-commits mailing list