[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

Hafiz Abid Qadeer via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 16 12:14:50 PST 2020


abidh marked an inline comment as done.
abidh added a comment.

In D91442#2394501 <https://reviews.llvm.org/D91442#2394501>, @jroelofs wrote:

> Seems reasonable.
>
> I could see someone wanting to use `--gcc-toolchain` to point at the baremetal toolchain for their target, but that's unlikely to work out of the box anyway. I'd love to know where the Generic_GCC toolchain is used in practice, since that's always seemed quite fragile to me.

Thanks for the review. I have handled the comment in updated diff. I will give it a few more days in case anyone else wants to comment before landing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91442/new/

https://reviews.llvm.org/D91442



More information about the cfe-commits mailing list