[PATCH] D91559: Add sysroot/lib to library search path of baremetal toolchain.

Jon Roelofs via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 16 12:14:11 PST 2020


jroelofs accepted this revision.
jroelofs added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:39
+    llvm::sys::path::append(SysRoot, "lib");
+    getFilePaths().push_back(std::string(SysRoot.str()));
+  }
----------------
Is the explicit `std::string` ctor call necessary here? Since `SmallString` has an `operator std::string() const`, I think this can just be:

```
getFilePaths().push_back(SysRoot);
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91559/new/

https://reviews.llvm.org/D91559



More information about the cfe-commits mailing list