[PATCH] D91546: [AMDGPU] Add option -munsafe-fp-atomics

Yaxun Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 16 10:17:57 PST 2020


yaxunl marked an inline comment as done.
yaxunl added inline comments.


================
Comment at: clang/include/clang/Basic/TargetOptions.h:78
 
+  /// \brief If enabled, allow AMDGPU unsafe floating point atomics.
+  bool AllowAMDGPUUnsafeFPAtomics = false;
----------------
tra wrote:
> I'm curious -- what does `unsafe` mean here?
unsafe means it does not follow requirements of other floating point options, e.g. it may flush denormals even if other fp options requires denormals not flushed. This allows user to relax fp restrictions on fp atomic instructions without relaxing fp requirements on other instructions.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91546/new/

https://reviews.llvm.org/D91546



More information about the cfe-commits mailing list