[PATCH] D91121: [InferAddrSpace] Teach to handle assumed address space.

Michael Liao via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 16 10:15:55 PST 2020


hliao added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp:533
+  if (!LD)
+    return -1;
+
----------------
tra wrote:
> Is there a suitable constant for `don't know` result?
I would say all generic pointers loaded from the constant memory are safe to be assumed as global ones (for AMDGPU). I explained the reason in the usage document. The constant memory could be modified by the host, where only global memory objects are visible.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91121/new/

https://reviews.llvm.org/D91121



More information about the cfe-commits mailing list