[PATCH] D91121: [InferAddrSpace] Teach to handle assumed address space.
Michael Liao via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Nov 13 09:57:59 PST 2020
hliao marked an inline comment as done.
hliao added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp:533
+ auto *Ty = V->getType();
+ if (!Ty->isPointerTy() ||
+ Ty->getPointerAddressSpace() != AMDGPUAS::FLAT_ADDRESS)
----------------
arsenm wrote:
> I would assume !isPointerTy would be unreachable
With a condition evaluation order revised, we could assert that now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91121/new/
https://reviews.llvm.org/D91121
More information about the cfe-commits
mailing list