[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

Rainer Orth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 13 04:39:48 PST 2020


ro added a comment.

In D90524#2393366 <https://reviews.llvm.org/D90524#2393366>, @glaubitz wrote:

> In D90524#2393320 <https://reviews.llvm.org/D90524#2393320>, @ro wrote:
>
>> In D90524#2393312 <https://reviews.llvm.org/D90524#2393312>, @glaubitz wrote:
>>
>>> Ping. It would be nice to get this finally merged so that the testsuite noise finally goes down on the sparc64 Linux worker.
>>
>> Please be a little more patient: one ping a week is considered appropriate, but after only two days is a bit over the top.
>
> The problem is that LLVM is a very fast moving target and when waiting long for changes to be merged, one constantly runs
> into the risk of having to rebase patches.

True, but it's the same for everyone.  Constantly pinging at short intervals won't get you faster reviews, but just creates noise and annoys possible reviewers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90524/new/

https://reviews.llvm.org/D90524



More information about the cfe-commits mailing list