[PATCH] D91330: [clangd] Ensure we test for compatibility of serialized index format

[Sam McCall via Phabricator via cfe-commits]

sammccall added inline comments.


================
Comment at: clang-tools-extra/clangd/test/index-serialization/version-is-correct.test:15
+# indexing sample.cpp would yield non-trivial values for those.
+# RUN: dexp %/S/Inputs/sample.idx -c="find B" | grep Bar
+
----------------
as discussed offline, maybe `|| not grep -v -e RUN: -e REQUIRES: %S` ?


================
Comment at: clang-tools-extra/clangd/test/index-serialization/version-is-correct.test:5
+# with
+# clangd-indexer \
+# clang-tools-extra/clangd/test/index-serialization/Inputs/sample.cpp > \
----------------
sammccall wrote:
> this isn't easy to copy/paste because of the comment markers.
> This file isn't interpreted so there's no need for them, I think...
> 
> It could also be formatted so it's easier to recognize the command (surround by blank lines, indent by a couple of spaces?)
again, we don't need the comment markers (but do need the line-continuations) for copy-paste


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91330/new/

https://reviews.llvm.org/D91330