[PATCH] D91337: [clangd] Add missing tests to rename feature
Haojian Wu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Nov 13 03:00:20 PST 2020
hokein accepted this revision.
hokein added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:618
+
+ // Templated method instantiation.
+ R"cpp(
----------------
hokein wrote:
> nit: we have groups of templates on ~Line 215 already, I'd suggest to move these template-related cases to there.
this looks like still undone.
I would move this section (from Line638-Line710) to Line307.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91337/new/
https://reviews.llvm.org/D91337
More information about the cfe-commits
mailing list