[PATCH] D91367: Serialization: Merge three diagnostics to simplify ASTReader::getInputFile, NFC

[Jan Svoboda via Phabricator via cfe-commits]

jansvoboda11 added a comment.

Getting rid of the duplication is definitely nice. I left one inline question about the terminology used.



================
Comment at: clang/include/clang/Basic/DiagnosticSerializationKinds.td:20
     "malformed block record in PCH file: '%0'">, DefaultFatal;
 def err_fe_pch_file_modified : Error<
+    "file '%0' has been modified since the "
----------------
I'm a bit confused by the fact that a diagnostic with `pch_file` in its name might output `module file` or `AST file` as well.

This file already contains a couple diagnostics that use a similar `%select` and have `module` in their name (e.g. `err_module_file_out_of_date`). Would it make sense to unify the terminology here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91367/new/

https://reviews.llvm.org/D91367