[PATCH] D91047: Add a call super attribute plugin example

Yafei Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 12 18:52:11 PST 2020


psionic12 marked 5 inline comments as done.
psionic12 added inline comments.


================
Comment at: clang/docs/ClangPlugins.rst:117
+Defining CallSuperAttr
+===================
+
----------------
aaron.ballman wrote:
> aaron.ballman wrote:
> > The number of underlines here looks off -- can you verify it's correct?
> This still appears to be incorrect and will cause build errors for the documentation.
Do you mean that there's a command to build the documentation and currently my patch will cause a failure on it?

I thought this ClangPlugins.rst is only an documentation with markdown, but seems that it's not what I thought?

Currently I will make sure there's no build error on the plugin itself and the regression test case, and make sure the
regression test will pass. Seems that's not enough, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91047/new/

https://reviews.llvm.org/D91047



More information about the cfe-commits mailing list