[PATCH] D91351: [tooling] Implement determinsitic ordering of CompilationDatabasePlugins

[Nathan Ridge via Phabricator via cfe-commits]

nridge added a comment.

Thanks for working on this!



================
Comment at: clang/lib/Tooling/CompilationDatabase.cpp:73
        CompilationDatabasePluginRegistry::entries()) {
+    Plugins.emplace_back(Database.getName(), Database.instantiate());
+  }
----------------
A side effect of this change is that every plugin will get instantiated, not just the ones for which we attempt a load.

Perhaps we should store a pointer to the entry in the vector here, and instantiate() in the second loop below?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91351/new/

https://reviews.llvm.org/D91351