[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

Nikita Popov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 12 11:54:53 PST 2020


nikic added a comment.

In D87188#2385619 <https://reviews.llvm.org/D87188#2385619>, @spatel wrote:

> D90554 <https://reviews.llvm.org/D90554> / f7eac51b9b <https://reviews.llvm.org/rGf7eac51b9b3f780c96ca41913293851c5acb465b>
> I think that change makes this patch ready to try again. If we do see regressions, then it should now be easy to adjust target-specific cost modeling of abs() intrinsics to fix those.

We still need to track down the miscompile that @mstorsjo reported before reapplying this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87188/new/

https://reviews.llvm.org/D87188



More information about the cfe-commits mailing list