[PATCH] D91333: [clang][SveEmitter] Fix enum declarations. [NFCI]

Joe Ellis via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 12 07:32:39 PST 2020


joechrisellis added a comment.

Thanks for the patch @fpetrogalli! One small comment from me, but not a blocker for me, so approved.



================
Comment at: clang/test/Sema/aarch64-sve-enums.c:14-15
+#include <arm_sve.h>
+enum svpattern a1 = SV_ALL;
+svpattern b1 = {1.0f};
+enum svprfop a2 = SV_PLDL1KEEP;
----------------
[nit] It would be good if you could add a small comment here explaining what this is doing. As far as I can tell, you're creating a typedef'd struct with the same identifier as the one defined in `arm_sve.h`, then checking that it does not overload `enum svpattern` defined in `arm_sve.h`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91333/new/

https://reviews.llvm.org/D91333



More information about the cfe-commits mailing list