[PATCH] D90622: clang: Don't assert on no_unique_address fields in @encode()

Nico Weber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 12 06:04:41 PST 2020


thakis added inline comments.


================
Comment at: clang/test/CodeGenObjCXX/encode.mm:91
 
-  // CHECK: @_ZN11rdar93574002ggE = constant [49 x i8] c"{vector<float, rdar9357400::fixed<4, -1> >=[4f]}\00"
+  // FIXME: This difference is due to D76801. It was probably an unintentional change. Maybe we want to undo it?
+  // CHECKCXX98: @_ZN11rdar93574002ggE = constant [49 x i8] c"{vector<float, rdar9357400::fixed<4, -1> >=[4f]}\00"
----------------
Raised this part on cfe-dev here: http://lists.llvm.org/pipermail/cfe-dev/2020-November/067188.html


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90622/new/

https://reviews.llvm.org/D90622



More information about the cfe-commits mailing list