[PATCH] D91089: [dllexport] Instantiate default ctor default args for explicit specializations (PR45811)

[Hans Wennborg via Phabricator via cfe-commits]

hans added a comment.

>> I don't think it makes sense to try to emit the closure until we have the ctor definition. I'll update the patch to handle this.
>
> Ok. That's a bit different than what MSVC is doing. It generates a closure constructor even if there is only a declaration. But I guess we are not aligning specifically with MSVC!
> Look good.

Right, I noticed that MSVC does this, but I couldn't come up with any reason why it would be necessary for us. Emitting the closure with the ctor definition should be sufficient.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91089/new/

https://reviews.llvm.org/D91089