[PATCH] D89158: [NewPM] Provide method to run all pipeline callbacks, used for -O0

Wed Nov 11 14:33:45 PST 2020

Meinersbur accepted this revision.
Meinersbur added a comment.
This revision is now accepted and ready to land.

In D89158#2389520 <https://reviews.llvm.org/D89158#2389520>, @aeubanks wrote:

> Thanks, I wasn't aware of this. Looks like other `opt -passes='default<O#>'` tests also look at if it present or not.

I'd prefer a solution that is agnostic to which pass plugins are compiled statically; however, this is also how Bye pass tests itself whether it us added to the pass pipeline too.

> The following already fail with `-DLLVM_BYE_LINK_INTO_TOOLS=ON`
>
>   LLVM :: Other/opt-O0-pipeline.ll
>   LLVM :: Other/opt-O2-pipeline.ll
>   LLVM :: Other/opt-O3-pipeline-enable-matrix.ll
>   LLVM :: Other/opt-O3-pipeline.ll
>   LLVM :: Other/opt-Os-pipeline.ll
>
> these are all legacy PM related.

Probably a consequence of not being enabled by default. Tests do not get updated.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89158/new/

https://reviews.llvm.org/D89158