[PATCH] D83025: [clang] Include type specifiers in typo correction when checking isCXXDeclarationSpecifiers.

[Haojian Wu via Phabricator via cfe-commits]

hokein added a comment.

In D83025#2389140 <https://reviews.llvm.org/D83025#2389140>, @aganea wrote:

> We're seeing the same issue mentionned in PR45498 <https://bugs.llvm.org/show_bug.cgi?id=45498>, but with the repro below. `git bisect` points to this patch. Could anyone please possibly confirm? Simply build clang with `-DLLVM_ENABLE_ASSERTIONS=ON`.
>
>   // compile with: clang-cl /c a.cpp
>   template < a > struct b;
>   template < bool a, class > using c = b< a >;
>   template < class > using d = void ;
>   template < class, class, class = void >
>   bool e template < class f, class g >
>   bool e< f, g, d< decltype(h(g())) > > template < class f, class g >
>   void i(f, g ) {
>     e< f, g >
>   }
>   template < class _BidIt2, c< e< _BidIt, _BidIt2 >, int > = 0 >
>   void h(_BidIt2) short do_tolower__Last {
>     i(do_tolower__First, do_tolower__Last)
>   }

thanks for the testcase. I'm not sure the patch is the root cause -- from the Bugzilla thread, the issue was reported in April which is prior to this patch.

btw, the issue seems to be gone on the trunk, I don't reproduce them with clang building from the trunk, I guess it might be fixed by some patches after llvm-11.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83025/new/

https://reviews.llvm.org/D83025