[PATCH] D91253: [Matrix] Update mangling to use paramterized vendor ext type syntax.

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 11 10:13:46 PST 2020


rjmccall added inline comments.


================
Comment at: clang/lib/AST/ItaniumMangle.cpp:3497
   // Mangle matrix types using a vendor extended type qualifier:
-  // U<Len>matrix_type<Rows><Columns><element type>
+  // u<Len>matrix_typeI<Rows><Columns><element type>E
   StringRef VendorQualifier = "matrix_type";
----------------
"Mangle matrix types as a vendor extended type:"


================
Comment at: clang/lib/AST/ItaniumMangle.cpp:3523
   mangleType(T->getElementType());
+  Out << "I";
 }
----------------
Your `I`s and `E`s are backwards.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91253/new/

https://reviews.llvm.org/D91253



More information about the cfe-commits mailing list