[PATCH] D91229: [FileCheck] Flip -allow-unused-prefixes to false by default

[Mircea Trofin via Phabricator via cfe-commits]

mtrofin added a comment.

In D91229#2387923 <https://reviews.llvm.org/D91229#2387923>, @jhenderson wrote:

> Maybe one way to do this is to do what @RKSimon suggests in the D90281 <https://reviews.llvm.org/D90281>, and to enable it on a per-directory basis using lit.local.cfg. That would potentially require changing the "0 or 1" occurrences limitation of the option, in favour of "last one wins" (or first one). Then, you make the change in the lit.local.cfg, flipping the default in each directory as you go. Eventually, once all tests that need it are covered, you can just change the default in FileCheck itself. How does that sound?

I haven't tried that yet. @RKSimon's case was that the folder was fixed, and we'd want to stop the bleeding there. Now, thinking more about it: because FileCheck won't accept more than one occurrence of --allow-unused-prefixes, if a directory has cases where we want to allow duplicates, we'd probably want lit.local.cfg to do 2 things:

- set --allow-unused-prefixes to false, to stop the bleeding - this would be removed when we switch defaults
- define a %UnusedPrefixesFileCheck (or better name) which is FileCheck with the flag set to true, which we'd then use where needed instead of FileCheck. This could stay like this even after we switch defaults.

I'm not very versed with lit.local.cfg - does the above capture what you imagined? (@RKSimon too)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91229/new/

https://reviews.llvm.org/D91229