[PATCH] D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups

Wed Nov 11 06:02:38 PST 2020

aaron.ballman added a comment.

In D91037#2387377 <https://reviews.llvm.org/D91037#2387377>, @njames93 wrote:

> Taking a step back, rather than worrying about if its an `ExprWithCleanups`. Shouldn't we just get the condition removing all implicit nodes.
>
>   const Expr* Cond = InnerIf->getCond()->ignoreImplicit();
>
> This has to be simpler and will likely future proof this against any other implicit nodes potentially added in future that can appear between the Condition and the binary operator.

Good call!

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91037/new/

https://reviews.llvm.org/D91037