[PATCH] D91124: [clangd] Call hierarchy (ClangdLSPServer layer)

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1228
+    Callback<Optional<std::vector<CallHierarchyOutgoingCall>>> Reply) {
+  Server->outgoingCalls(Params.Item, std::move(Reply));
+}
----------------
as mentioned in the previous review, let's just reply with none/empty here, with a fixme.


================
Comment at: clang-tools-extra/clangd/test/call-hierarchy.test:39
+---
+{"jsonrpc":"2.0","id":2,"method":"callHierarchy/incomingCalls","params":{"item":{"data":"F0E64FE3F8FEA480","kind":12,"name":"callee","range":{"end":{"character":16,"line":0},"start":{"character":0,"line":0}},"selectionRange":{"end":{"character":11,"line":0},"start":{"character":5,"line":0}},"uri":"test:///main.cpp"}}}
+#      CHECK:  "id": 2,
----------------
it feels fragile to depend on USRs here :/

can we change this lit file to only test for preparecallhierarchy with a wildcard match for the symbolid and introduce a new test into ClangdLSPServerTests.cpp for the incomingcalls ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91124/new/

https://reviews.llvm.org/D91124