[PATCH] D90984: Update matchers to be traverse-aware

Stephen Kelly via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 10 12:23:00 PST 2020


steveire added inline comments.


================
Comment at: clang/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp:2368
   NonTrivial m_nt;
-  HasCtorInits() : NoSpecialMethods(), m_i(42) {}
 };
----------------
aaron.ballman wrote:
> Was this originally testing behavior with explicitly initializing an implicitly generated ctor (since that's also an implicit node)? Perhaps this change should be reverted and we make a second test?
Good point, done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90984/new/

https://reviews.llvm.org/D90984



More information about the cfe-commits mailing list