[PATCH] D91158: Fix the DeclContextLookupResult::iterator non-copyable.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 10 09:17:42 PST 2020


sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/include/clang/AST/DeclBase.h:1249
       llvm::iterator_adaptor_base<iterator, ResultTy::iterator,
-                                  std::random_access_iterator_tag,
-                                  NamedDecl *const>;
+                                  std::random_access_iterator_tag, NamedDecl *>;
 
----------------
I wonder if this was meant to be `const NamedDecl *` - note that begin()/end() are const.

However I'm not sure (clang AST is always funny about const) and that would be a breaking change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91158/new/

https://reviews.llvm.org/D91158



More information about the cfe-commits mailing list