[PATCH] D91109: [OMPIRBuilder] Start 'Create' methods with lower case. NFC.

Michael Kruse via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 9 16:39:09 PST 2020


Meinersbur created this revision.
Meinersbur added a reviewer: jdoerfert.
Meinersbur added a project: OpenMP.
Herald added subscribers: cfe-commits, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_amini, hiraditya.
Herald added a reviewer: ftynse.
Herald added projects: clang, MLIR, LLVM.
Meinersbur requested review of this revision.
Herald added subscribers: sstefan1, stephenneuendorffer, nicolasvasilache.

For consistency with the IRBuilder, OpenMPIRBuilder has method names starting with 'Create'. However, the LLVM coding style has methods names starting with lower case letters, as all other OpenMPIRBuilder already methods do. The clang-tidy configuration used by Phabricator also warns about the naming violation, adding noise to the reviews.

This patch renames all `OpenMPIRBuilder::CreateXYZ` methods to `OpenMPIRBuilder::createXYZ`, and updates all in-tree callers.

I tested check-llvm, check-clang, check-mlir and check-flang to ensure that I did not miss a caller.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D91109

Files:
  clang/lib/CodeGen/CGOpenMPRuntime.cpp
  clang/lib/CodeGen/CGStmtOpenMP.cpp
  llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h
  llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp
  llvm/lib/Transforms/IPO/OpenMPOpt.cpp
  llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp
  mlir/lib/Target/LLVMIR/ModuleTranslation.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D91109.304009.patch
Type: text/x-patch
Size: 28827 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20201110/49089c2f/attachment-0001.bin>


More information about the cfe-commits mailing list