[PATCH] D91144: Add utility for testing if we're matching nodes AsIs

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 10 05:20:27 PST 2020


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!



================
Comment at: clang/lib/ASTMatchers/ASTMatchersInternal.cpp:195
+bool ASTMatchFinder::isTraversalAsIs() const {
+  return getASTContext().getParentMapContext().getTraversalKind() == TK_AsIs;
+}
----------------
I don't insist, but I do wonder if we want to inline the definition in the header file rather than put it in the implementation file so that call sites have an easier time inlining the functionality.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91144/new/

https://reviews.llvm.org/D91144



More information about the cfe-commits mailing list