[PATCH] D91102: [clangd] Enhance Clangd rename testing coverage

[Haojian Wu via Phabricator via cfe-commits]

hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.

Thanks. Please update the patch description when landing it (the description is stale now).



================
Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:95
-  // rename is runnning on all "^" points, and "[[]]" ranges point to the
-  // identifier that is being renamed.
   llvm::StringRef Tests[] = {
----------------
nit: keep this comment.


================
Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:501
+
+      // Member function.
+      R"cpp(
----------------
nit: put this case around `Class methods overrides`.


================
Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:509
+
+      // Alias.
+      R"cpp(
----------------
while we have a group of alias tests, worth to move the `Namespace alias` to here. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91102/new/

https://reviews.llvm.org/D91102