[PATCH] D90116: [llvm] CMake: Force MSVC to read code as UTF-8

[Aleksandr Platonov via Phabricator via cfe-commits]

ArcsinX added a comment.

In D90116#2383999 <https://reviews.llvm.org/D90116#2383999>, @kbobyrev wrote:

> Sigh, this doesn't work because we have things like https://docs.microsoft.com/en-us/windows/win32/api/traceloggingprovider/nf-traceloggingprovider-tracelogging_define_provider and https://docs.microsoft.com/en-us/windows/win32/tracelogging/tracelogging-native-quick-start in Windows sanitizer code:
>
> http://lab.llvm.org:8011/#/builders/127/builds/1161/steps/4/logs/stdio

I have double checked that I do not have such errors with Visual Studio 2019 (just built compiler-rt with your patch)

I am not sure is it a bug of VS 2017 or not, but according to official documentation execution-character-set is obsolete since VS 2015 update 2 ( https://docs.microsoft.com/en-us/cpp/preprocessor/execution-character-set?view=msvc-160 ), so it's strange to me why it's still in use inside VS 2017 system headers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90116/new/

https://reviews.llvm.org/D90116