[PATCH] D72281: [Matrix] Add matrix type to Clang.
Richard Smith - zygoloid via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Nov 9 21:26:07 PST 2020
rsmith added inline comments.
Herald added a subscriber: dang.
================
Comment at: clang/lib/AST/ItaniumMangle.cpp:3353-3371
+ auto &ASTCtx = getASTContext();
+ unsigned BitWidth = ASTCtx.getTypeSize(ASTCtx.getSizeType());
+ llvm::APSInt Rows(BitWidth);
+ Rows = T->getNumRows();
+ mangleIntegerLiteral(ASTCtx.getSizeType(), Rows);
+ llvm::APSInt Columns(BitWidth);
+ Columns = T->getNumColumns();
----------------
This mangling doesn't conform to the Itanium ABI rules: you're missing the `I` ... `E` surrounding the template arguments. Also, the ABI rules let you use `u`... manglings now if you want.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72281/new/
https://reviews.llvm.org/D72281
More information about the cfe-commits
mailing list