[PATCH] D89158: [NewPM] Provide method to run all pipeline callbacks, used for -O0

Arthur Eubanks via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 9 17:57:38 PST 2020


aeubanks added a comment.

In D89158#2384337 <https://reviews.llvm.org/D89158#2384337>, @Meinersbur wrote:

> In D89158#2384156 <https://reviews.llvm.org/D89158#2384156>, @aeubanks wrote:
>
>> Are there passes that should be running at -O0 that aren't target specific? Otherwise the callbacks should only add passes if the optimization level isn't -O0.
>
> At least for the legacy pass manager, there is an EP_EnabledOnOptLevel0 insertion point, that pass plugins can use to insert passes at -O0.

That should be obsolete by the OptimizationLevel parameter in the callbacks. The callbacks can inspect the OptimizationLevel to see if it's O0 or not when deciding to add a pass to the pipeline.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89158/new/

https://reviews.llvm.org/D89158



More information about the cfe-commits mailing list