[PATCH] D91103: [tooling] Add support for fixits that indicate code will need reformatting
Jim Ingham via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Nov 9 14:50:35 PST 2020
jingham added a comment.
IIUC, the expression parser part of this change suppresses any Fixits that are clang-tidy type rewrites, is that right? If so that is indeed the correct behavior. But that fact that this change implements that behavior is entirely non-obvious at the call site. Could you either add a comment here explaining to point of the test or maybe wrap the test in a method on the FixItHint class so that it's self documenting?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91103/new/
https://reviews.llvm.org/D91103
More information about the cfe-commits
mailing list