[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

[Duncan P. N. Exon Smith via Phabricator via cfe-commits]

dexonsmith added a comment.

In D82756#2383317 <https://reviews.llvm.org/D82756#2383317>, @jansvoboda11 wrote:

> Thanks, `Jan Svoboda` and `jan_svoboda at apple.com` is fine. Is it possible to add @dang as a co-author? `git log` says he uses `Daniel Grumberg` and `dany.grumberg at gmail.com`.

I don't think there's a Git feature to support that, but I'll credit Daniel in the commit message:

> Port some floating point options to new option marshalling infrastructure
>
> This ports a number of OpenCL and fast-math flags for floating point
> over to the new marshalling infrastructure.
>
> As part of this, `OptInFFlag` was enhanced to allow other flags to imply
> it, via `DefaultAnyOf<>`. For example:
>
>   defm signed_zeros : OptOutFFlag<"signed-zeros", ...,
>     "LangOpts->NoSignedZero",
>     DefaultAnyOf<[cl_no_signed_zeros, menable_unsafe_fp_math]>>;
>
> defines `-fsigned-zeros` (`false`) and `-fno-signed-zeros` (`true`)
> linked to the keypath `LangOpts->NoSignedZero`, defaulting to `false`,
> but set to `true` implicitly if one of `-cl-no-signed-zeros` or
> `-menable-unsafe-fp-math` is on.
>
> Note that the initial patch was written Daniel Grumberg.

I just rebased and I'm building and running tests now... should get back to check on it and commit later today at some point.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82756/new/

https://reviews.llvm.org/D82756