[PATCH] D89959: UBSAN: emit distinctive traps in trapping mode
Tim Northover via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Nov 9 07:10:37 PST 2020
t.p.northover added inline comments.
================
Comment at: llvm/include/llvm/IR/Intrinsics.td:1242
+def int_ubsantrap : Intrinsic<[], [llvm_i8_ty],
+ [IntrNoReturn, IntrCold, ImmArg<ArgIndex<0>>]>;
----------------
jdoerfert wrote:
> should this be readonly and inaccesiblememonly?
For `readonly` I'd say no (LangRef says "if a readonly function [...] has other side-effects, the behavior is undefined"), `inaccessiblememonly` maybe, but I doubt the definitions were written with something like a trap in mind so the whole topic seems pretty fuzzy to me.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89959/new/
https://reviews.llvm.org/D89959
More information about the cfe-commits
mailing list