[PATCH] D91078: [clang-format] do not break before @tags in JS comments

Krasimir Georgiev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 9 07:00:00 PST 2020


krasimir added inline comments.


================
Comment at: clang/unittests/Format/FormatTestJS.cpp:194
-            format("/** @returns {string} jsdoc line 12 */",
-                   getGoogleJSStyleWithColumns(20)));
   EXPECT_EQ("/**\n"
----------------
this actually demonstrates a bug fixed by this patch: with 20 column limit, the comment should be split. The new behavior makes the test with a column limit of 25 redundant, so folded the two of them.


================
Comment at: clang/unittests/Format/FormatTestJS.cpp:205
-            " */",
-            format("/** @returns {string} jsdoc line 12  */",
                    getGoogleJSStyleWithColumns(20)));
----------------
this is an exact duplicate as the check on old line 190; removed


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91078/new/

https://reviews.llvm.org/D91078



More information about the cfe-commits mailing list