[PATCH] D91035: [NFC, Refactor] Convert FunctionDefinitionKind from DeclSpech.h to a scoped enum
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Nov 9 06:00:30 PST 2020
aaron.ballman added inline comments.
================
Comment at: clang/include/clang/Sema/DeclSpec.h:1837
/// Actually a FunctionDefinitionKind.
- unsigned FunctionDefinition : 2;
+ FunctionDefinitionKind FunctionDefinition : 2;
----------------
I think we need to keep this as `unsigned` because some compilers struggle with bit-fields of enumeration types (even when the enumeration underlying type is fixed): https://godbolt.org/z/P8x8Kz
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91035/new/
https://reviews.llvm.org/D91035
More information about the cfe-commits
mailing list