[PATCH] D90956: [clang][SVE] Additional macros implied by `-msve-vector-bits=<N>`.

[Peter Waller via Phabricator via cfe-commits]

peterwaller-arm added a comment.

Suggestion: Where referencing sections you could include the title "3.7.3.3. Behavior specific to SVE vectors" instead of "3.7.3.3" for example. I think this makes it easier to spot misreferences and gives future souls a better chance to understand the context without indirection.



================
Comment at: clang/test/CodeGen/aarch64-sve-acle-__ARM_FEATURE_SVE_PREDICATE_OPERATORS.cpp:19
+auto f4(pred x, pred y) { return x & y; } // Returns a pred
+#endif
----------------
Do we need tests for unary operators, assignment and comparison operators?
(Page 28, item 3, subitems, 1, 3, 4)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90956/new/

https://reviews.llvm.org/D90956