[PATCH] D90992: [clang-tidy] Use vfs::FileSystem when getting config

Nico Weber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Nov 8 06:28:41 PST 2020


thakis added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/ClangTidyOptions.cpp:366
     }
-    return OptionsSource(*ParsedOptions, ConfigFile.c_str());
+    return OptionsSource(*ParsedOptions, ConfigFile.str());
   }
----------------
This breaks bootstrap builds against the gcc 5.3 libstdc++: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8864218000842553296/+/steps/package_clang/0/stdout?format=raw

```
 /b/s/w/ir/cache/builder/src/third_party/llvm/clang-tools-extra/clang-tidy/ClangTidyOptions.cpp:366:12: error: no matching constructor for initialization of 'clang::tidy::ClangTidyOptionsProvider::OptionsSource' (aka 'pair<clang::tidy::ClangTidyOptions, basic_string<char>>')
     return OptionsSource(*ParsedOptions, ConfigFile.str());
            ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```

Can we undo the change on this line?

PTAL!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90992/new/

https://reviews.llvm.org/D90992



More information about the cfe-commits mailing list