[PATCH] D90944: [clang-tidy] implement misc-mt-unsafe

[Vasily Kulikov via Phabricator via cfe-commits]

segoon added a comment.

In D90944#2379688 <https://reviews.llvm.org/D90944#2379688>, @njames93 wrote:

> It appears to not check for signs that the code is running in a multi threaded manner, This will result in many false positives in code that is known to be single threaded.

I'm not sure there is a trustworthy check whether a source is going to be used in MT environment. A program can be linked with threads libraries but still use a single thread and use MT-unsafe API with no problem. I'd rather disable the check by default and let the user explicitly enable the check. I'm not sure what's clang-tidy policy for such case - should I create a new module instead of "misc"?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90944/new/

https://reviews.llvm.org/D90944