[PATCH] D87981: [X86] AMX programming model prototype.

Fri Nov 6 08:42:32 PST 2020

akashk4 requested changes to this revision.
akashk4 added a comment.
This revision now requires changes to proceed.

It would be great if TILE_RELEASE is supported in the backend, so the scope of transaction is known and the configurations are at least stored to memory properly.

================
Comment at: llvm/lib/Target/X86/X86TileConfig.cpp:101
+  unsigned SubIdx = (BitSize == 8) ? X86::sub_8bit : X86::sub_16bit;
+  unsigned Opc = (BitSize == 8) ? X86::MOV8mr : X86::MOV16mr;
+  MachineInstr *NewMI =
----------------
I do not understand why wasn't PSTTILECFG used to store config to memory.  I guess it will be difficult to do that because we do not know the scope of a transaction since the TILE_RELEASE is not supported.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87981/new/

https://reviews.llvm.org/D87981