[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

Chuyang Chen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 6 03:55:07 PST 2020


nomanous added a comment.

In D90448#2376710 <https://reviews.llvm.org/D90448#2376710>, @dblaikie wrote:

> How's this compare to the similar checks for variable templates? Is there some code/checking we could share here?

The code of checks for variable templates is just before the additional code. But the conditions of if statement and the format of diagnostics are different, so it may be better to do the check for static member instantiation separately. And I have reused the type comparing function (with an argument different).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90448/new/

https://reviews.llvm.org/D90448



More information about the cfe-commits mailing list